fix: incorrect calculation of backlink field for self-relations

[ymc9]

Fixes #1530

[coderabbitai]

Walkthrough

Walkthrough

The changes ensure that fields in the data model do not become self-referential during processing by adding a condition to skip processing when otherField is the same as field. Additionally, a test is introduced to address and validate the issue of runtime error occurrence when disconnecting a self-relation in a schema.

Changes

File Path	Change Summary
packages/sdk/src/model-meta-generator.ts	Added a condition to skip processing when otherField is the same as field to prevent self-referential links.
tests/regression/tests/issue-1530.test.ts	Introduced new test cases related to issue 1530, focusing on schema loading, data manipulation, and assertions.

Sequence Diagram(s)

N/A

Assessment against linked issues

Objective	Addressed	Explanation
Resolve runtime error when disconnecting a self-relation (Issue #1530)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

packages/sdk/src/model-meta-generator.ts (2)

Line range hint 331-331: Replace isNaN with Number.isNaN.

The current use of isNaN is flagged as unsafe because it performs type coercion. Using Number.isNaN provides a safer alternative as it does not coerce types.

- if (isNaN(v)) {
+ if (Number.isNaN(v)) {

Also applies to: 334-334

---

Line range hint 364-366: Remove unnecessary else clause.

The else clause after early return statements is unnecessary and can be removed to simplify the code.

- } else {
-    return undefined;
- }

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 00fc461 and b2c3921.

Files selected for processing (2)

• packages/sdk/src/model-meta-generator.ts (1 hunks)
• tests/regression/tests/issue-1530.test.ts (1 hunks)

Additional context used

Biome

packages/sdk/src/model-meta-generator.ts

[error] 364-366: This else clause can be omitted because previous branches break early.

Unsafe fix: Omit the else clause.

(lint/style/noUselessElse)

---

[error] 331-331: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.

(lint/suspicious/noGlobalIsNan)

---

[error] 334-334: isNaN is unsafe. It attempts a type coercion. Use Number.isNaN instead.

See the MDN documentation for more details.
Unsafe fix: Use Number.isNaN instead.

(lint/suspicious/noGlobalIsNan)

Additional comments not posted (2)

tests/regression/tests/issue-1530.test.ts (1)

1-36: Comprehensive test suite for issue 1530.

This test suite effectively covers the scenario described in the PR, from loading the schema to performing the update operations and verifying the results. The use of enhance and prisma seems appropriate for the operations needed.

packages/sdk/src/model-meta-generator.ts (1)

298-301: Correct handling of self-referential fields.

The addition of a check to skip self-referential fields is a direct and effective solution to the issue described. This prevents erroneous backlink calculations that could lead to runtime errors.