fix(trpc): create/upsert routers shouldn't be generated for delegate models

[ymc9]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes introduce enhancements to the tRPC plugin within the generator.ts file. They incorporate additional imports, modifications to model usage, and introduce checks for delegate models in the generateModelCreateRouter function. Furthermore, a new test case has been added to plugin-interaction.test.ts to validate the interaction of the trpc plugin within a polymorphic schema setup.

Changes

File Path	Change Summary
packages/plugins/trpc/src/generator.ts	- Added imports for isDelegateModel and DataModel
	- Modified Model usage to include DataModel and isDataModel
	- Added delegate models check in generateModelCreateRouter function
tests/integration/tests/enhancements/...	- Added new test case it('trpc') to validate plugin interaction with the trpc plugin in a polymorphic schema setup

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a4efa6e and 8c6a517.

Files selected for processing (2)

• packages/plugins/trpc/src/generator.ts (2 hunks)
• tests/integration/tests/enhancements/with-delegate/plugin-interaction.test.ts (1 hunks)

Additional comments not posted (3)

tests/integration/tests/enhancements/with-delegate/plugin-interaction.test.ts (1)

26-40: LGTM! Verify schema setup and dependencies.

The new test case correctly sets up the schema and loads it with the necessary dependencies.

Ensure that the schema setup and dependencies are correct and sufficient for the test.

packages/plugins/trpc/src/generator.ts (2)

4-4: Verify the necessity and correctness of added imports.

The imports for isDelegateModel and DataModel appear to be necessary for the new functionality.

Ensure that these imports are used correctly and are necessary for the changes made.

Also applies to: 13-13

---

291-295: LGTM! Verify the check for delegate models.

The check correctly identifies delegate models and skips create or upsert operations.

Ensure that the logic for identifying delegate models and skipping operations is correct and covers all edge cases.

Also applies to: 300-304