fix(redwood): fix incorrect error type thrown

[ymc9]

No description provided.

[coderabbitai]

Walkthrough

Walkthrough

The updates involve renaming the error code CONSTRAINED_FAILED to CONSTRAINT_FAILED in the PrismaErrorCode enum across multiple files. This change corrects the error code used in error handling logic, ensuring consistency in error categorization. Additionally, the import statement for ValidationError was modified to include it in the error handling framework, although its usage is not specified in the changes.

Changes

File	Change Summary
.../redwood/src/graphql.ts	Updated error code from PrismaErrorCode.CONSTRAINED_FAILED to PrismaErrorCode.CONSTRAINT_FAILED. Added import of ValidationError.
.../runtime/src/constants.ts	Renamed CONSTRAINED_FAILED to CONSTRAINT_FAILED in PrismaErrorCode enum.
.../runtime/src/enhancements/policy/policy-utils.ts	Updated error code from PrismaErrorCode.CONSTRAINED_FAILED to PrismaErrorCode.CONSTRAINT_FAILED.
.../server/src/api/rest/index.ts	Updated error handling logic in handlePrismaError method, changing error code reference.
.../server/src/api/rpc/index.ts	Changed key in ERROR_STATUS_MAPPING from PrismaErrorCode.CONSTRAINED_FAILED to PrismaErrorCode.CONSTRAINT_FAILED.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 32c258c and 5bfd695.

Files selected for processing (3)

• packages/misc/redwood/src/graphql.ts (2 hunks)
• packages/runtime/src/constants.ts (1 hunks)
• packages/runtime/src/enhancements/policy/policy-utils.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• packages/runtime/src/constants.ts

Additional comments not posted (3)

packages/misc/redwood/src/graphql.ts (2)

Line range hint 49-57: LGTM! The error code correction is appropriate.

The change from CONSTRAINED_FAILED to CONSTRAINT_FAILED ensures that the correct error code is used for error handling.

---

1-1: Verify the usage of ValidationError.

The ValidationError import is added, but its usage is not shown in the provided code.

Run the following script to verify the usage of ValidationError in the codebase:

Verification successful

---

ValidationError is used in the codebase.

The ValidationError import is correctly utilized in the file packages/misc/redwood/src/graphql.ts.

• packages/misc/redwood/src/graphql.ts: return new ValidationError(error.message);

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of `ValidationError` in the codebase.

# Test: Search for the usage of `ValidationError`. Expect: At least one occurrence.
rg --type javascript 'ValidationError'

Length of output: 73

---

Script:

#!/bin/bash
# Description: Verify the usage of `ValidationError` in the codebase.

# Test: Search for the usage of `ValidationError`. Expect: At least one occurrence.
rg --type ts 'ValidationError'

Length of output: 9074

packages/runtime/src/enhancements/policy/policy-utils.ts (1)

1218-1218: LGTM! The error code correction is appropriate.

The change from CONSTRAINED_FAILED to CONSTRAINT_FAILED ensures that the correct error code is used for error handling.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5bfd695 and b1bcfe9.

Files selected for processing (2)

• packages/server/src/api/rest/index.ts (1 hunks)
• packages/server/src/api/rpc/index.ts (1 hunks)

Additional comments not posted (2)

packages/server/src/api/rpc/index.ts (1)

21-21: LGTM! Correct error code for accurate error handling.

The change from PrismaErrorCode.CONSTRAINED_FAILED to PrismaErrorCode.CONSTRAINT_FAILED ensures that the correct error code is used for mapping to HTTP status 403.

packages/server/src/api/rest/index.ts (1)

1592-1592: LGTM! Correct error code for accurate error handling.

The change from PrismaErrorCode.CONSTRAINED_FAILED to PrismaErrorCode.CONSTRAINT_FAILED ensures that the correct error code is checked for handling Prisma client errors.