fix: incorrect policy injection for post-update rules with deep member access

[ymc9]

Fixes #1648

[coderabbitai]

Walkthrough

Walkthrough

The changes involve refactoring the ExpressionWriter class to improve how future member access is handled, specifically by introducing a new method for stripping future calls. Additionally, new test cases have been added to validate policy enforcement in complex schemas, addressing a previously reported bug related to access control in one-to-one relationships.

Changes

Files	Change Summary
packages/schema/src/plugins/enhancer/policy/expression-writer.ts	Refactored future member access handling in ExpressionWriter class by introducing stripFutureCall method for better readability and maintainability.
tests/integration/tests/enhancements/with-policy/post-update.test.ts	Added a new test case for deep member access to validate policy enforcement in a multi-model schema.
tests/regression/tests/issue-1648.test.ts	Introduced a regression test case for issue 1648, verifying access control policies in a Prisma-based schema with user, profile, and post models.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure proper handling of future member access (Issue #1648)	✅
Validate access control policies in one-to-one relations (Issue #1648)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 62c624d and 1a8301e.

Files selected for processing (3)

• packages/schema/src/plugins/enhancer/policy/expression-writer.ts (2 hunks)
• tests/integration/tests/enhancements/with-policy/post-update.test.ts (1 hunks)
• tests/regression/tests/issue-1648.test.ts (1 hunks)

Additional comments not posted (4)

tests/regression/tests/issue-1648.test.ts (1)

1-42: LGTM!

The test case is well-structured and covers the intended policy enforcement scenario for issue 1648.

The code changes are approved.

tests/integration/tests/enhancements/with-policy/post-update.test.ts (1)

556-597: LGTM!

The test case is well-structured and covers the intended policy enforcement scenario for deep member access.

The code changes are approved.

packages/schema/src/plugins/enhancer/policy/expression-writer.ts (2)

381-383: LGTM!

The update to use stripFutureCall improves the readability and maintainability of the code.

The code changes are approved.

---

467-498: LGTM!

The method stripFutureCall is well-implemented and enhances code readability and maintainability.

The code changes are approved.