fix(polymorphism): unique constraint name disambiguation

[Gabrola]

Fixes #2001

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request assigns the result of adding a unique attribute to a new variable (uniqueConstraint) in the Prisma schema generator. It then enhances the unique constraint logic by conditionally generating and adding a named map argument to the constraint arguments when named constraints are supported. Additionally, a new regression test for the Zenstack schema is added which verifies the proper handling of models and their constraints.

Changes

File(s)	Change Summary
packages/schema/.../schema-generator.ts	Assigned the result of model.addAttribute('@@unique', ...) to uniqueConstraint. Added conditional logic to generate a constraintName and push a new map argument to uniqueConstraint.args when supportNamedConstraints is true.
tests/regression/tests/issue-2001.test.ts	Added a regression test suite for the Zenstack schema covering multiple models and constraints without pushing changes to the database.

Sequence Diagram(s)

sequenceDiagram
    participant G as SchemaGenerator
    participant M as Model
    G->>M: addAttribute('@@unique', args)
    M-->>G: uniqueConstraint object
    alt supportNamedConstraints is true
        G->>G: Generate fieldNames and truncate to form constraintName
        G->>uniqueConstraint: Append new 'map' argument with constraintName
    end

Loading

Possibly related PRs

• fix: polymorphic logical Prisma schema has identifiers with too long names #1482: Refactors unique constraint logic in the same file, aligning with the improved handling.
• fix: Validation error when @@unique attribute is defined in the different model of the relation field #1430: Addresses validation errors related to the @@unique attribute, directly relating to the changes in constraint handling.
• fix(schema): Provide a truncated name for unique constraints with polymorphic fk #1999: Modifies the unique constraint name construction, showing a direct link to the current changes.

Suggested reviewers

• ymc9

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e379f8 and 4672baf.

📒 Files selected for processing (2)

• packages/schema/src/plugins/prisma/schema-generator.ts (1 hunks)
• tests/regression/tests/issue-2001.test.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.