Skip to content

[DEV-2000] add phase wire impedances #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgreav merged 5 commits into from
Jan 4, 2025
Merged

[DEV-2000] add phase wire impedances #166

kgreav merged 5 commits into from
Jan 4, 2025

Conversation

@kgreav
Copy link
Member

@kgreav kgreav commented Jan 4, 2025 •
edited
Loading

Description

Implements data model change for phase level impedances, as well as fixes/finishes implementing the HCM data model change.

Test Steps

Merge merge merge straight to prod

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members if so.

Small breaking change that only impacts internal use at the moment

@kgreav
Progress commit
17279b2 
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
@kgreav
Progress commit again
9af4fb6 
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
@kgreav
Add phase impedances and corrections for HCM data model change
c413651 
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
@kgreav
Complete SDK change
92a3063 
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
@kgreav
Fix tests
d62eb02 
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
@ryanjcoleman
Copy link
Member

ryanjcoleman commented Jan 4, 2025

Task linked: DEV-1751 Update Python SDK
Task linked: DEV-2000 Update Python SDK

@kgreav kgreav marked this pull request as ready for review January 4, 2025 03:03
@kgreav kgreav changed the title Dev 2000 add phase wire impedances [DEV-2000] add phase wire impedances Jan 4, 2025
@kgreav kgreav merged commit 3b2c26e into DEV-1751-HCM-intervention-data-model-change Jan 4, 2025
2 of 3 checks passed
@kgreav kgreav deleted the DEV-2000-add-phase-wire-impedances branch January 4, 2025 03:03
kgreav added a commit that referenced this pull request Jan 4, 2025
@kgreav
[DEV-2000] add phase wire impedances (#166)
f402307 
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
kgreav added a commit that referenced this pull request Jan 4, 2025
@Esaotuelr @kgreav
[DEV-1751] HCM intervention data model change (#162)
1c3a2fa 
[DEV-2000] Add phase wire impedances (#166)

Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
Co-authored-by: kgreav <kurt.greaves@zepben.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kgreav @ryanjcoleman