Skip to content

Conversation

@chestm007
Copy link
Contributor

Description

Network trace was ridiculously slow, noticeable only when running a very large dataset. this change addresses that

If you have added new dependencies to the project please state why.

Test Steps

run a trace on a big network, downstream from a feeder with > 50000 IdentifiedObjects. execution time should easily be sub 1s

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • [ X ] I have performed a self review of my own code (including checking issues raised when creating the PR).
  • [ X ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • [ X ] I have commented my code in any hard-to-understand or hacky areas.
  • [ X ] I have handled all new warnings generated by the compiler or IDE.
  • [ X ] I have rebased onto the target branch (usually main).

Documentation

  • [ X ] I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • [ X ] I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
@chestm007 chestm007 requested a review from charlta June 19, 2025 02:52
…nless people are hacking into our internals, gross)

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@charlta charlta merged commit 2e3c0de into main Jun 19, 2025
3 checks passed
@charlta charlta deleted the fix-slow-traces branch June 19, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants