Skip to content

Conversation

@charlta
Copy link
Member

@charlta charlta commented Oct 28, 2025

Description

Updated EwbDataFilePaths to be an abstract class that supports variants, matching what is in the JVM SDK. This includes adding LocalEwbDataFilePaths which is a local file system implementation of EwbDataFilePaths, and should be used in place of the old EwbDataFilePaths.

Test Steps

Unit tests.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

You should no longer create a EwbDataFilePaths directly, you should use the LocalEwbDataFilePaths instread, but there is probably a very limited set of people (if any) that even need to do that.

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@ryanjcoleman
Copy link
Member

Task linked: DEV-4393 Update Python SDK

@charlta charlta marked this pull request as ready for review October 28, 2025 11:44
@charlta charlta requested a review from a team October 28, 2025 11:45
@charlta charlta merged commit efca00c into main Oct 28, 2025
4 checks passed
@charlta charlta deleted the DEV-4393-variant-file-paths branch October 28, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants