judges-action#652: fix Fbe::FakeOctokit

[Yegorov]

Need for zerocracy/judges-action#652

Summary by CodeRabbit

• Bug Fixes

  • Issues and pull requests with numbers 142 and 143 are now correctly marked as closed in relevant views.

• Tests

  • Updated tests to verify that the closed state is accurately reflected for these issues and pull requests.

[coderabbitai]

Walkthrough

The changes update the mock data returned by the issue method to include a state: 'closed' attribute for issues 142 and 143. Corresponding test expectations were also updated to match this new attribute, ensuring consistency between the mock implementation and the test assertions.

Changes

File(s)	Change Summary
lib/fbe/octo.rb	Added state: 'closed' to the hash returned by the issue method for issues 142 and 143.
test/fbe/test_octo.rb	Updated test expectations to include state: 'closed' for issues 142 and 143.

Poem

In the land of code, two issues closed,
Their state now marked, as the story goes.
Tests align with every change,
Mock and reality, in perfect range.
A rabbit hops with pride today—
Consistency wins, hip hip hooray! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 774a36e and fc87536.

📒 Files selected for processing (2)

• lib/fbe/octo.rb (2 hunks)
• test/fbe/test_octo.rb (2 hunks)

🔇 Additional comments (4)

lib/fbe/octo.rb (2)

669-669: LGTM! State attribute correctly added for issue 142.

The addition of state: 'closed' to issue 142's mock data is consistent with the other attributes (closed_at, closed_by) that indicate this is a closed issue.

---

682-682: LGTM! State attribute correctly added for issue 143.

The addition of state: 'closed' to issue 143's mock data is consistent with the other attributes (closed_at, closed_by) that indicate this is a closed issue.

test/fbe/test_octo.rb (2)

345-345: LGTM! Test expectation correctly updated for issue 142.

The test expectation now includes state: 'closed' which matches the updated mock data in the issue method. This ensures consistency between the mock implementation and test assertions.

---

358-358: LGTM! Test expectation correctly updated for issue 143.

The test expectation now includes state: 'closed' which matches the updated mock data in the issue method. This ensures consistency between the mock implementation and test assertions.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Yegorov]

@yegor256 please merge this pr

[yegor256]

@rultor release, tag is 0.25.1

[rultor]

@rultor release, tag is 0.25.1

@yegor256 OK, I will release it now. Please check the progress here.

[rultor]

@rultor release, tag is 0.25.1

@yegor256 Done! FYI, the full log is here (took me 7min).

[0crat]

@Yegorov Hey there! 👋 Thanks for your contribution! You've earned +4 points, which is the minimum reward we give. Here's the breakdown: +16 for submitting, -16 because there wasn't a code review (which is super important!), and -8 because there were only 4 hits-of-code (we're looking for at least 20). Don't worry though, we bumped you up to the minimum 4 points. Keep the contributions coming – remember, more code and getting it reviewed can boost your points next time! Your current balance is +206. Looking forward to your next speedy yet quality contribution! 💻🚀