Skip to content

Documentation & minor gas optimisation during userOpExecution #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leekt merged 4 commits into from
Nov 28, 2023
Merged

Documentation & minor gas optimisation during userOpExecution #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3297aa6
Add storage slot documentation & run coverage
KONFeature Nov 25, 2023
ba42cef
Gas improvment on disabled mode check during execution
KONFeature Nov 25, 2023
e5d70cd
Missing funds check gas improvments
KONFeature Nov 25, 2023
d22e056
Adding a bit of comments
KONFeature Nov 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
179 changes: 160 additions & 19 deletions .gas-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,160 @@
KernelExecutionTest:test_mode_2() (gas: 593614)
KernelExecutionTest:test_mode_2() (gas: 611256)
KernelExecutionTest:test_mode_2_1() (gas: 589400)
KernelExecutionTest:test_mode_2_erc165() (gas: 2485466)
KernelExecutionTest:test_revert_when_mode_disabled() (gas: 192767)
KernelExecutionTest:test_sudo() (gas: 216219)
KernelHelperTest:testIntersect(uint48,uint48,uint48,uint48) (runs: 256, μ: 2379, ~: 2383)
KernelTest:test_disable_mode() (gas: 170757)
KernelTest:test_disable_mode() (gas: 172824)
KernelTest:test_external_call_default() (gas: 28844)
KernelTest:test_external_call_execution() (gas: 520197)
KernelTest:test_initialize_twice() (gas: 20515)
KernelTest:test_initialize_twice() (gas: 20537)
KernelTest:test_set_default_validator() (gas: 427634)
KernelTest:test_set_default_validator() (gas: 429679)
KernelTest:test_set_execution() (gas: 477930)
KernelTest:test_set_execution() (gas: 479975)
KernelTest:test_validate_signature() (gas: 171911)
KernelTest:test_validate_signature() (gas: 175529)
KernelECDSATest:test_default_validator_disable() (gas: 0)
KernelECDSATest:test_default_validator_disable() (gas: 180311)
KernelECDSATest:test_default_validator_enable() (gas: 0)
KernelECDSATest:test_default_validator_enable() (gas: 187800)
KernelECDSATest:test_disable_mode() (gas: 182795)
KernelECDSATest:test_disable_mode() (gas: 192079)
KernelECDSATest:test_eip712() (gas: 15684)
KernelECDSATest:test_eip712() (gas: 15684)
KernelECDSATest:test_enable_then_mode_1() (gas: 277994)
KernelECDSATest:test_enable_then_mode_1() (gas: 286106)
KernelECDSATest:test_external_call_batch_execute_fail() (gas: 23628)
KernelECDSATest:test_external_call_batch_execute_fail() (gas: 29534)
KernelECDSATest:test_external_call_batch_execute_success() (gas: 20629)
KernelECDSATest:test_external_call_batch_execute_success() (gas: 26536)
KernelECDSATest:test_external_call_default() (gas: 23511)
KernelECDSATest:test_external_call_default() (gas: 29338)
KernelECDSATest:test_external_call_execute_delegatecall_fail() (gas: 22499)
KernelECDSATest:test_external_call_execute_delegatecall_fail() (gas: 28381)
KernelECDSATest:test_external_call_execute_delegatecall_option_fail() (gas: 20434)
KernelECDSATest:test_external_call_execute_delegatecall_option_fail() (gas: 26329)
KernelECDSATest:test_external_call_execute_delegatecall_success() (gas: 19738)
KernelECDSATest:test_external_call_execute_delegatecall_success() (gas: 25621)
KernelECDSATest:test_external_call_execute_fail() (gas: 21968)
KernelECDSATest:test_external_call_execute_fail() (gas: 27862)
KernelECDSATest:test_external_call_execute_success() (gas: 20070)
KernelECDSATest:test_external_call_execute_success() (gas: 25987)
KernelECDSATest:test_external_call_execution() (gas: 497819)
KernelECDSATest:test_external_call_execution() (gas: 510696)
KernelECDSATest:test_fail_validate_not_activate() (gas: 0)
KernelECDSATest:test_fail_validate_not_activate() (gas: 303491)
KernelECDSATest:test_fail_validate_wrongsignature() (gas: 24904)
KernelECDSATest:test_fail_validate_wrongsignature() (gas: 34133)
KernelECDSATest:test_get_nonce() (gas: 25179)
KernelECDSATest:test_get_nonce() (gas: 25201)
KernelECDSATest:test_get_nonce(uint192) (runs: 1024, μ: 19842, ~: 19842)
KernelECDSATest:test_get_nonce(uint192) (runs: 1024, μ: 19842, ~: 19842)
KernelECDSATest:test_ignore() (gas: 868)
KernelECDSATest:test_initialize() (gas: 126784)
KernelECDSATest:test_initialize() (gas: 154121)
KernelECDSATest:test_initialize_twice() (gas: 18555)
KernelECDSATest:test_initialize_twice() (gas: 18698)
KernelECDSATest:test_mode_2() (gas: 243052)
KernelECDSATest:test_mode_2() (gas: 250243)
KernelECDSATest:test_revert_when_mode_disabled() (gas: 199003)
KernelECDSATest:test_revert_when_mode_disabled() (gas: 208287)
KernelECDSATest:test_set_default_validator() (gas: 417145)
KernelECDSATest:test_set_default_validator() (gas: 423335)
KernelECDSATest:test_set_execution() (gas: 458142)
KernelECDSATest:test_set_execution() (gas: 468303)
KernelECDSATest:test_should_emit_event_on_receive() (gas: 23220)
KernelECDSATest:test_should_emit_event_on_receive() (gas: 23220)
KernelECDSATest:test_should_receive_erc1155() (gas: 701145)
KernelECDSATest:test_should_receive_erc1155() (gas: 701171)
KernelECDSATest:test_should_receive_erc1155_batch() (gas: 728411)
KernelECDSATest:test_should_receive_erc1155_batch() (gas: 728411)
KernelECDSATest:test_should_receive_erc721() (gas: 597680)
KernelECDSATest:test_should_receive_erc721() (gas: 597702)
KernelECDSATest:test_should_return_address_if_deployed() (gas: 21970)
KernelECDSATest:test_should_return_address_if_deployed() (gas: 21976)
KernelECDSATest:test_sudo() (gas: 170002)
KernelECDSATest:test_sudo() (gas: 179450)
KernelECDSATest:test_sudo_wrongSig() (gas: 102566)
KernelECDSATest:test_sudo_wrongSig() (gas: 115709)
KernelECDSATest:test_transfer_ownership() (gas: 178398)
KernelECDSATest:test_upgrade() (gas: 21292)
KernelECDSATest:test_upgrade() (gas: 21292)
KernelECDSATest:test_validateUserOp_fail_invalid_mode() (gas: 26550)
KernelECDSATest:test_validateUserOp_fail_invalid_mode() (gas: 26550)
KernelECDSATest:test_validateUserOp_fail_not_entryPoint() (gas: 30591)
KernelECDSATest:test_validateUserOp_fail_not_entryPoint() (gas: 30634)
KernelECDSATest:test_validate_signature() (gas: 155714)
KernelECDSATest:test_validate_signature() (gas: 194502)
KernelHelperTest:testIntersect(uint48,uint48,uint48,uint48) (runs: 1024, μ: 871, ~: 869)
KillSwitchValidatorTest:test_default_validator_disable() (gas: 180432)
KillSwitchValidatorTest:test_default_validator_enable() (gas: 187921)
KillSwitchValidatorTest:test_disable_mode() (gas: 182916)
KillSwitchValidatorTest:test_eip712() (gas: 15820)
KillSwitchValidatorTest:test_enable_then_mode_1() (gas: 348586)
KillSwitchValidatorTest:test_external_call_batch_execute_fail() (gas: 29622)
KillSwitchValidatorTest:test_external_call_batch_execute_success() (gas: 26558)
KillSwitchValidatorTest:test_external_call_default() (gas: 29426)
KillSwitchValidatorTest:test_external_call_execute_delegatecall_fail() (gas: 28469)
KillSwitchValidatorTest:test_external_call_execute_delegatecall_option_fail() (gas: 26439)
KillSwitchValidatorTest:test_external_call_execute_delegatecall_success() (gas: 25709)
KillSwitchValidatorTest:test_external_call_execute_fail() (gas: 27906)
KillSwitchValidatorTest:test_external_call_execute_success() (gas: 26075)
KillSwitchValidatorTest:test_external_call_execution() (gas: 510817)
KillSwitchValidatorTest:test_fail_validate_not_activate() (gas: 303601)
KillSwitchValidatorTest:test_fail_validate_wrongsignature() (gas: 34276)
KillSwitchValidatorTest:test_force_unblock() (gas: 391544)
KillSwitchValidatorTest:test_get_nonce() (gas: 25201)
KillSwitchValidatorTest:test_get_nonce(uint192) (runs: 1024, μ: 19930, ~: 19930)
KillSwitchValidatorTest:test_ignore() (gas: 956)
KillSwitchValidatorTest:test_initialize() (gas: 154209)
KillSwitchValidatorTest:test_initialize_twice() (gas: 18643)
KillSwitchValidatorTest:test_mode_2() (gas: 312761)
KillSwitchValidatorTest:test_revert_when_mode_disabled() (gas: 199157)
KillSwitchValidatorTest:test_set_default_validator() (gas: 423434)
KillSwitchValidatorTest:test_set_execution() (gas: 468424)
KillSwitchValidatorTest:test_should_emit_event_on_receive() (gas: 23330)
KillSwitchValidatorTest:test_should_fail_with_not_implemented_isValidSignature() (gas: 9236)
KillSwitchValidatorTest:test_should_fail_with_not_implemented_isValidSignature(bytes32,bytes) (runs: 1024, μ: 9601, ~: 9556)
KillSwitchValidatorTest:test_should_fail_with_not_implemented_validCaller() (gas: 10157)
KillSwitchValidatorTest:test_should_fail_with_not_implemented_validCaller(address,bytes) (runs: 1024, μ: 9749, ~: 9703)
KillSwitchValidatorTest:test_should_receive_erc1155() (gas: 701233)
KillSwitchValidatorTest:test_should_receive_erc1155_batch() (gas: 728499)
KillSwitchValidatorTest:test_should_receive_erc721() (gas: 597790)
KillSwitchValidatorTest:test_should_return_address_if_deployed() (gas: 22086)
KillSwitchValidatorTest:test_sudo() (gas: 179549)
KillSwitchValidatorTest:test_sudo_wrongSig() (gas: 115830)
KillSwitchValidatorTest:test_upgrade() (gas: 21314)
KillSwitchValidatorTest:test_validateUserOp_fail_invalid_mode() (gas: 26638)
KillSwitchValidatorTest:test_validateUserOp_fail_not_entryPoint() (gas: 30708)
KillSwitchValidatorTest:test_validate_signature() (gas: 194579)
SessionKeyValidatorTest:test_default_validator_disable() (gas: 180311)
SessionKeyValidatorTest:test_default_validator_enable() (gas: 187800)
SessionKeyValidatorTest:test_disable_mode() (gas: 182795)
SessionKeyValidatorTest:test_eip712() (gas: 15684)
SessionKeyValidatorTest:test_enable_then_mode_1() (gas: 286128)
SessionKeyValidatorTest:test_external_call_batch_execute_fail() (gas: 29534)
SessionKeyValidatorTest:test_external_call_batch_execute_success() (gas: 26536)
SessionKeyValidatorTest:test_external_call_default() (gas: 29338)
SessionKeyValidatorTest:test_external_call_execute_delegatecall_fail() (gas: 28381)
SessionKeyValidatorTest:test_external_call_execute_delegatecall_option_fail() (gas: 26351)
SessionKeyValidatorTest:test_external_call_execute_delegatecall_success() (gas: 25621)
SessionKeyValidatorTest:test_external_call_execute_fail() (gas: 27862)
SessionKeyValidatorTest:test_external_call_execute_success() (gas: 26009)
SessionKeyValidatorTest:test_external_call_execution() (gas: 510718)
SessionKeyValidatorTest:test_fail_validate_not_activate() (gas: 303513)
SessionKeyValidatorTest:test_fail_validate_wrongsignature() (gas: 34165)
SessionKeyValidatorTest:test_get_nonce() (gas: 25179)
SessionKeyValidatorTest:test_get_nonce(uint192) (runs: 1024, μ: 19842, ~: 19842)
SessionKeyValidatorTest:test_ignore() (gas: 890)
SessionKeyValidatorTest:test_initialize() (gas: 154121)
SessionKeyValidatorTest:test_initialize_twice() (gas: 18555)
SessionKeyValidatorTest:test_mode_2() (gas: 250298)
SessionKeyValidatorTest:test_revert_when_mode_disabled() (gas: 199003)
SessionKeyValidatorTest:test_scenario_batch((uint8,uint8,uint8,uint8,uint48,uint48,uint48,uint48,bool,bool,bool,bool),(uint8)) (runs: 1024, μ: 43997409, ~: 32002162)
SessionKeyValidatorTest:test_scenario_non_batch((uint8,uint8,uint8,uint8,uint48,uint48,uint48,uint48,bool,bool,bool,bool)) (runs: 1024, μ: 17511495, ~: 17372686)
SessionKeyValidatorTest:test_set_default_validator() (gas: 423335)
SessionKeyValidatorTest:test_set_execution() (gas: 468303)
SessionKeyValidatorTest:test_should_emit_event_on_receive() (gas: 23242)
SessionKeyValidatorTest:test_should_receive_erc1155() (gas: 701145)
SessionKeyValidatorTest:test_should_receive_erc1155_batch() (gas: 728411)
SessionKeyValidatorTest:test_should_receive_erc721() (gas: 597724)
SessionKeyValidatorTest:test_should_return_address_if_deployed() (gas: 22003)
SessionKeyValidatorTest:test_sudo() (gas: 179450)
SessionKeyValidatorTest:test_sudo_wrongSig() (gas: 115731)
SessionKeyValidatorTest:test_upgrade() (gas: 21292)
SessionKeyValidatorTest:test_validateUserOp_fail_invalid_mode() (gas: 26574)
SessionKeyValidatorTest:test_validateUserOp_fail_not_entryPoint() (gas: 30634)
SessionKeyValidatorTest:test_validate_signature() (gas: 194502)
TestCallee:test_ignore() (gas: 206)
TestCounter:test_ignore() (gas: 164)
TestERC1155:test_ignore() (gas: 328)
TestERC20:test_ignore() (gas: 389)
TestERC721:test_ignore() (gas: 399)
TestExecutor:test_ignore() (gas: 130)
TestPaymaster:test_ignore() (gas: 174)
TestValidator:test_ignore() (gas: 351)
Loading