Skip to content

Feat/add validate #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leekt merged 3 commits into from
Jan 29, 2024
Merged

Feat/add validate #73

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eb400b
feat: implement validateSignature of WeightedECDSAValidator
adnpark Jan 25, 2024
8e686e5
fix: init totalWeight as 0 in validateSignature
adnpark Jan 26, 2024
eb1cee1
Fix validSignature for WeightedECDSAValidator
derekchiang Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/validator/WeightedECDSAValidator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,25 @@ contract WeightedECDSAValidator is EIP712, IKernelValidator {
return false;
}

function validateSignature(bytes32, bytes calldata) external pure returns (ValidationData) {
function validateSignature(bytes32 hash, bytes calldata signature) external view returns (ValidationData) {
WeightedECDSAValidatorStorage storage strg = weightedStorage[msg.sender];
if (strg.threshold == 0) {
return SIG_VALIDATION_FAILED;
}

uint256 sigCount = signature.length / 65;
if (sigCount == 0) {
return SIG_VALIDATION_FAILED;
}
uint256 totalWeight = 0;
address signer;
for (uint256 i = 0; i < sigCount; i++) {
signer = ECDSA.recover(hash, signature[i * 65:(i + 1) * 65]);
totalWeight += guardian[signer][msg.sender].weight;
if (totalWeight >= strg.threshold) {
return packValidationData(ValidAfter.wrap(0), ValidUntil.wrap(0));
}
}
return SIG_VALIDATION_FAILED;
}
}