fix(discov): avoid duplicate watch events and monitors,duplicate addKv#5576
Open
YangXiaowu wants to merge 2 commits into
Open
fix(discov): avoid duplicate watch events and monitors,duplicate addKv#5576YangXiaowu wants to merge 2 commits into
YangXiaowu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR fixes two issues in etcd discovery watchers:
PUTevents for the same key/value caused subscribers torepeatedly append the same key in the local container, which could lead to
unbounded memory growth.
watch goroutines instead of reusing the existing watcher.
What is changed?
PUTevents when the key already has the same value.OnDelete(old)beforeOnAdd(new).Monitorcalls for the same watch key from startingduplicate watch streams.
handling.
Tests