Skip to content

ensure data-length is not negative in zts_lwip_eth_tx #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pionere wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ensure data-length is not negative in zts_lwip_eth_tx #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/VirtualTap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,10 @@ signed char zts_lwip_eth_tx(struct netif* n, struct pbuf* p)
bufptr += q->len;
totalLength += q->len;
}
int len = totalLength - sizeof(struct eth_hdr);
if (len < 0) {
return ERR_IF;
}
struct eth_hdr* ethhdr;
ethhdr = (struct eth_hdr*)buf;

Expand All @@ -400,7 +404,6 @@ signed char zts_lwip_eth_tx(struct netif* n, struct pbuf* p)
dest_mac.setTo(ethhdr->dest.addr, 6);

char* data = buf + sizeof(struct eth_hdr);
int len = totalLength - sizeof(struct eth_hdr);
int proto = Utils::ntoh((uint16_t)ethhdr->type);
tap->_handler(tap->_arg, NULL, tap->_net_id, src_mac, dest_mac, proto, 0, data, len);

Expand Down