Conversation
kevinssgh
requested review from
brewmaster012,
fadeev,
kingpinXD,
lumtis and
ws4charlie
as code owners
lumtis
reviewed
Sep 18, 2023
Comment on lines
+166
to
+169
| } else { | ||
| ethZRC20Addr, _ := smokeTest.SystemContract.GasCoinZRC20ByChainId(&bind.CallOpts{}, big.NewInt(5)) | ||
| smokeTest.ETHZRC20Addr = ethZRC20Addr | ||
| smokeTest.ETHZRC20, _ = zrc20.NewZRC20(smokeTest.ETHZRC20Addr, smokeTest.zevmClient) |
Contributor
There was a problem hiding this comment.
As far as I can tell, we support either local or testnet?
I would suggest checking here stressTestArgs.network == "TESTNET" and returning error otherwise
| StressCmd.Flags().StringVar(&stressTestArgs.deployerAddress, "addr", "0xE5C5367B8224807Ac2207d350E60e1b6F27a7ecC", "--addr <eth address>") | ||
| StressCmd.Flags().StringVar(&stressTestArgs.deployerPrivateKey, "privKey", "d87baf7bf6dc560a252596678c12e41f7d1682837f05b29d411bc3f78ae2c263", "--privKey <eth private key>") | ||
| StressCmd.Flags().BoolVar(&stressTestArgs.local, "local", true, "--local") | ||
| StressCmd.Flags().StringVar(&stressTestArgs.network, "network", "PRIVNET", "--network PRIVNET") |
Contributor
There was a problem hiding this comment.
I don't know if we use privnet naming anywhere else but I think localnet is a more common language to specify the local network
Contributor
Author
There was a problem hiding this comment.
I agree it isn't the correct language for this case but it is the name of the build flag used for the smoketest and config files.
kingpinXD
approved these changes
Sep 20, 2023
CharlieMc0
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modifications to run stress test on specific chain.
Closes: #1136
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: