fix: Mock mainnet begin block deployment fix btc duplicate payment#1266
Merged
ws4charlie merged 4 commits intomock-mainnet-begin-block-deploymentfrom Oct 11, 2023
Conversation
ws4charlie
requested review from
brewmaster012,
fadeev,
kevinssgh,
kingpinXD and
lumtis
as code owners
…begin-block-deployment-fix-btc-duplicate-payment
brewmaster012
approved these changes
Oct 11, 2023
10 tasks
lumtis
pushed a commit
that referenced
this pull request
Oct 16, 2023
* add begin blocked deployemnts for mock mainent * panic when telemetry server does not start * report bitcoin fee in sat/byte instead of stas/KB * compensate for the low gaslimit on BTC * fix: Mock mainnet begin block deployment fix btc duplicate payment (#1259) * special handling to avoid duplicate payment on bitcoin outbound nonce 0 * use cctx amount instead of txResult's amount because it's not available in bitcoin mainnet --------- Co-authored-by: charliec <charliec@zetachain.com> * fix: Mock mainnet begin block deployment fix btc duplicate payment (#1266) * special handling to avoid duplicate payment on bitcoin outbound nonce 0 * use cctx amount instead of txResult's amount because it's not available in bitcoin mainnet * mockmain bootstrap from double payment on nonce 0 --------- Co-authored-by: charliec <charliec@zetachain.com> * revert hard coded outTx hash for nonce 0 * removed division by 1000 in fee calculation (#1275) Co-authored-by: charliec <charliec@zetachain.com> * try to fix smoketest due to BTC ZRC20 audit --------- Co-authored-by: Tanmay <tanmay.bhattacharya.smit@gmail.com> Co-authored-by: Tanmay <tanmay@zetachain.com> Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com> Co-authored-by: charliec <charliec@zetachain.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After double payment on nonce 0, the expected nonce mark UTXO was already spent
txid:
71395db26ae81147dd79176e394c598b9480036c5ef6e44608b3356283168872vout: 0 amount: 2000To recover, we can use this UTXO as the nonce-mark
txid:
26aa6b32b7f16cc6671ac1419e91bac5fb78b5d24536df0da0120a3f75bf9116vout: 0 amount: 2000Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: