refactor: remove duplicate funtion name IsEthereum#1279
Merged
lumtis merged 4 commits intozeta-chain:developfrom Oct 14, 2023
Merged
refactor: remove duplicate funtion name IsEthereum#1279lumtis merged 4 commits intozeta-chain:developfrom
lumtis merged 4 commits intozeta-chain:developfrom
Conversation
kingpinXD
approved these changes
Oct 12, 2023
lumtis
approved these changes
Oct 12, 2023
Contributor
lumtis
left a comment
There was a problem hiding this comment.
Looking good, thanks for the contribution, I see there is a small conflict to resolve
Contributor
Author
Conflict resolved |
Closed
Contributor
|
Not sure why this gosec got raised now, created a PR for it #1288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We already have the function
IsEthereumChainthat has the same function asIsEthereum, so the duplicate functionIsEthereumshould be removed.Closes: #1271
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: