Skip to content

fix: minor fixes to stateful upgrade#1280

Merged
kevinssgh merged 5 commits intodevelopfrom
upgrade-test-fixes
Oct 16, 2023
Merged

fix: minor fixes to stateful upgrade#1280
kevinssgh merged 5 commits intodevelopfrom
upgrade-test-fixes

Conversation

@kevinssgh
Copy link
Contributor

Description

  • Increased update block to allow enough time for additional tests to complete.
  • Removed pull cmd since the target version might be a tag.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinssgh kevinssgh merged commit 817cc47 into develop Oct 16, 2023
@lumtis lumtis deleted the upgrade-test-fixes branch October 27, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants