Skip to content

fix: btc decode address#1528

Merged
lumtis merged 17 commits intodevelopfrom
fix-btc-decode
Jan 9, 2024
Merged

fix: btc decode address#1528
lumtis merged 17 commits intodevelopfrom
fix-btc-decode

Conversation

@kingpinXD
Copy link
Member

@kingpinXD kingpinXD commented Jan 5, 2024

Description

Adds a wrapper function for btcUtils.DecodeAddress
Note: This PR only adds a solution to avoid panic. The original reason that can create these malformed addresses might be a more significant concern and is being looked into separately.

Closes: (#1527)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kingpinXD kingpinXD changed the title fix:btc decode address fix: btc decode address Jan 5, 2024
@kingpinXD kingpinXD marked this pull request as ready for review January 5, 2024 18:52
kingpinXD and others added 3 commits January 7, 2024 09:37
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@kingpinXD kingpinXD requested a review from lumtis January 7, 2024 14:38
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Copy link
Collaborator

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis merged commit 0642dbb into develop Jan 9, 2024
@lumtis lumtis deleted the fix-btc-decode branch January 9, 2024 18:39
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants