fix(rpc): reduce websocket message limit to 10MB#1555
Merged
Conversation
lumtis
requested review from
brewmaster012,
fadeev,
kevinssgh,
kingpinXD and
ws4charlie
as code owners
lumtis
changed the title
rpc): reduce websocket message limit to 10MB
kingpinXD
approved these changes
Jan 11, 2024
Member
kingpinXD
left a comment
kingpinXD
left a comment
There was a problem hiding this comment.
LGTM ,
We should consider some testing with the consumers of the websocket though , to see if it affects them by any chance ?
Contributor
Author
|
ws4charlie
approved these changes
Jan 11, 2024
Contributor
ws4charlie
left a comment
ws4charlie
left a comment
There was a problem hiding this comment.
makes sense to me if GoLang accepts 10MB by default on the HTTP service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: https://github.com/zeta-chain/security/issues/50