Skip to content

ci: fix the cleanup step in the rc-release and publish-release pipelines#1580

Merged
lumtis merged 4 commits intodevelopfrom
fix-cleanup-step
Jan 21, 2024
Merged

ci: fix the cleanup step in the rc-release and publish-release pipelines#1580
lumtis merged 4 commits intodevelopfrom
fix-cleanup-step

Conversation

@gzukel
Copy link
Contributor

@gzukel gzukel commented Jan 13, 2024

Description

fix: fix the cleanup step in the rc-release and publish-release pipelines

Closes: No-Ticket-Adhoc-Fix

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@gzukel gzukel requested a review from a team as a code owner January 13, 2024 02:17
@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Jan 13, 2024
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can rename fix to ci

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Copy link
Member

@CharlieMc0 CharlieMc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from DevOps. Timing for merging and change log refer to @lumtis

@lumtis lumtis changed the title fix: fix the cleanup step in the rc-release and publish-release pipelines ci: fix the cleanup step in the rc-release and publish-release pipelines Jan 21, 2024
@lumtis lumtis merged commit e06711b into develop Jan 21, 2024
@lumtis lumtis deleted the fix-cleanup-step branch January 21, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes to CI pipeline or github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants