Skip to content

fix: skip unsupported chain parameters#1581

Merged
lumtis merged 2 commits intodevelopfrom
fix-zetaclient-supported-chains
Jan 16, 2024
Merged

fix: skip unsupported chain parameters#1581
lumtis merged 2 commits intodevelopfrom
fix-zetaclient-supported-chains

Conversation

@ws4charlie
Copy link
Contributor

Description

  • skip unsupported chain parameters

Closes: 1575

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lumtis lumtis merged commit a0e4f62 into develop Jan 16, 2024
@lumtis lumtis deleted the fix-zetaclient-supported-chains branch January 16, 2024 18:49
lumtis added a commit that referenced this pull request Jan 19, 2024
… gas limit (#1601)

* chore: v12.0.0 changelog (#1578)

* fix: skip unsupported chain parameters (#1581)

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* remove debug zetaclient1

* remove comments

* tx resend

* complete renaming

* change log level and create constants

* increase retry value

* test change gas limit for outbound

* refactor vote inbound outbound into separate files

* add monitoring capability for outbound txs

* changelog

---------

Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
lumtis added a commit that referenced this pull request Jan 24, 2024
… gas limit (#1601)

* chore: v12.0.0 changelog (#1578)

* fix: skip unsupported chain parameters (#1581)

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* remove debug zetaclient1

* remove comments

* tx resend

* complete renaming

* change log level and create constants

* increase retry value

* test change gas limit for outbound

* refactor vote inbound outbound into separate files

* add monitoring capability for outbound txs

* changelog

---------

Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
lumtis added a commit that referenced this pull request Jan 25, 2024
* refactor(`hotfix`): support retrying sending inbound vote with higher gas limit (#1601)

* chore: v12.0.0 changelog (#1578)

* fix: skip unsupported chain parameters (#1581)

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* remove debug zetaclient1

* remove comments

* tx resend

* complete renaming

* change log level and create constants

* increase retry value

* test change gas limit for outbound

* refactor vote inbound outbound into separate files

* add monitoring capability for outbound txs

* changelog

---------

Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>

* fix: some necessary code refactor for banned address and bug fix during refactor (#1603)

* cherry picked: fixed ChainParams equality check and added changelog entry

* respect isSupported in zetaclient observation

* add some RPC diagnosis log

* guard against multiple deposits

* make cosmos go sec linter happy

* update e2e tests

* Update zetaclient/bitcoin_client.go

Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>

---------

Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: Charlie Chen <charliec@zetachain.com>
Co-authored-by: brewmaster012 <88689859+brewmaster012@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zetaclient needs to skip chains having their 'IsSupported' flag disabled

3 participants