feat: support retrying sending inbound vote with higher gas limit#1591
feat: support retrying sending inbound vote with higher gas limit#1591
Conversation
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
| type ZetaCoreBridger interface { | ||
| PostSend(zetaGasLimit uint64, msg *crosschaintypes.MsgVoteOnObservedInboundTx) (string, string, error) | ||
| PostReceiveConfirmation( | ||
| PostVoteInbound(gasLimit, retryGasLimit uint64, msg *crosschaintypes.MsgVoteOnObservedInboundTx) (string, string, error) |
There was a problem hiding this comment.
retryGasLimit - I see you're passing the execution gas limit here. Should the name be retry gas limit instead of execution gas limit?
|
Closing in favor of #1601 |
Description
Decrease the default gas limit for inbound vote and increase it when the tx failed with a out of gas error.
The tx result is checked in another Go routine
Add the same functionality for outbound vote. (When processing outbound when reverting the gas limit must be higher because of the swaps to pay for the gas on the sending chain)
Also do some renaming and create new files for the different Post functions:
PostSend=>PostVoteInboundPostReceiveConfirmation=>PostVoteOutboundCloses: #1579