Skip to content

refactor: Optimize return#1628

Merged
lumtis merged 3 commits intozeta-chain:developfrom
fx0x55:optimize-return
Jan 26, 2024
Merged

refactor: Optimize return#1628
lumtis merged 3 commits intozeta-chain:developfrom
fx0x55:optimize-return

Conversation

@fx0x55
Copy link
Contributor

@fx0x55 fx0x55 commented Jan 24, 2024

Description

delete redundant judgments

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

delete redundant judgments
Copy link
Member

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , thanks for the contribution.
Please add an entry in the changelog

@fx0x55 fx0x55 requested a review from kingpinXD January 26, 2024 00:44
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lumtis lumtis merged commit 62e1bfd into zeta-chain:develop Jan 26, 2024
@fx0x55 fx0x55 deleted the optimize-return branch July 4, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants