Skip to content

chore: remove standalone network#1694

Merged
kingpinXD merged 20 commits intodevelopfrom
remove-standalone-network
Feb 13, 2024
Merged

chore: remove standalone network#1694
kingpinXD merged 20 commits intodevelopfrom
remove-standalone-network

Conversation

@kingpinXD
Copy link
Member

@kingpinXD kingpinXD commented Feb 2, 2024

Description

  • Removes standalone network
  • Replaces assert with require to maintain consistency

Closes:#1595
#1696

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@lumtis lumtis linked an issue Feb 2, 2024 that may be closed by this pull request
@kingpinXD kingpinXD marked this pull request as draft February 2, 2024 18:55
@github-actions
Copy link

github-actions bot commented Feb 6, 2024

!!!WARNING!!!
nosec detected in the following files: zetaclient/btc_signer_test.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Feb 6, 2024
@kingpinXD kingpinXD marked this pull request as ready for review February 6, 2024 17:25
@lumtis
Copy link
Contributor

lumtis commented Feb 6, 2024

I think there has been a misunderstanding, we should replace assert with require

@lumtis lumtis self-requested a review February 11, 2024 21:36
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kingpinXD kingpinXD merged commit 95bdb7e into develop Feb 13, 2024
@kingpinXD kingpinXD deleted the remove-standalone-network branch February 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove standalone_network

3 participants