refactor: make staking keeper private#1760
Merged
Conversation
kingpinXD
requested review from
brewmaster012,
fadeev,
kevinssgh,
lumtis,
skosito and
ws4charlie
as code owners
lumtis
approved these changes
Feb 15, 2024
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
LGTM
Need to change chore->refactor
lumtis
changed the title
kevinssgh
approved these changes
Feb 16, 2024
lumtis
pushed a commit
that referenced
this pull request
Feb 19, 2024
lumtis
added a commit
that referenced
this pull request
Feb 21, 2024
* rename smoke test to e2e * changelog * some more renaming * move smoketest package to e2e * fix imports * rename sm to r * add more documentation in Dockerfile * remove old upgrade test * remove no longer used scripts * script renaming * remove eth dir * cleaning up in orchestratort * remove some lines * p2p diag * fix lint * fix docker upgrade * group start zetacore and zetaclient scripts * simplify docker files * add stress test command * refine readme * add localnet makefile entry * some renaming * refactor: make staking keeper private (#1760) * refactor: fix invalid zrc20withdraw (#1766) * fix lint * comments iteration 1 * review iteration 2 * proto --------- Co-authored-by: Tanmay <tanmay@zetachain.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: