test: improve fungible module coverage#1762
Merged
Conversation
skosito
requested review from
brewmaster012,
fadeev,
kevinssgh,
kingpinXD,
lumtis and
ws4charlie
as code owners
skosito
commented
Feb 15, 2024
skosito
commented
Feb 15, 2024
skosito
commented
Feb 15, 2024
kingpinXD
approved these changes
Feb 16, 2024
lumtis
approved these changes
Feb 19, 2024
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
Great job!
The coverage looks good to me. We're integrating code coverage so will check the global coverage afterward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increases the coverage of mentioned parts of fungible module. Adds some generic helper methods for mocking evm client. I think there is a bit more room to move some testing code around (for example deploySystemContract) and probably it's better to mock happy paths too. Here I basically had to introduce more evm client mocking because it is hard to mimic real world evmCall reverts (and no need to in unit tests, we can mock that external dependency).
Relates to: #1742 . It is part 1 of adding more coverage, will add missing tests for
system_contract.goin follow up PR.Type of change
Tests
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: