Skip to content

ci: add codecov coverage upload as part of the CI#1781

Merged
lumtis merged 8 commits intodevelopfrom
add-codecov
Feb 21, 2024
Merged

ci: add codecov coverage upload as part of the CI#1781
lumtis merged 8 commits intodevelopfrom
add-codecov

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Feb 19, 2024

Description

Closes: #1704

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Feb 19, 2024
@lumtis lumtis marked this pull request as draft February 20, 2024 09:15
@lumtis lumtis marked this pull request as ready for review February 20, 2024 09:53
Copy link
Member

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just question how is 60% selected to threshold?

not relevant to this PR, but maybe we can consider using -mode=count heat map flag to get more insight, especially when developing tests locally, which should give how many is each statement covered, i think it should mostly be visible in html reports, but might not be needed

@ws4charlie
Copy link
Contributor

ws4charlie commented Feb 21, 2024

Does codecov give combined coverage of both e2e tests + unit tests or just unit tests? zetaclient don't have enough unit tests to run (don't know the current coverage yet) at the moment and can lead to CI failure.

@lumtis
Copy link
Contributor Author

lumtis commented Feb 21, 2024

lgtm, just question how is 60% selected to threshold?

Just a value taken for now based on our OKR.

not relevant to this PR, but maybe we can consider using -mode=count heat map flag to get more insight, especially when developing tests locally, which should give how many is each statement covered, i think it should mostly be visible in html reports, but might not be needed

Good suggestion, we can think about it in the future

Does codecov give combined coverage of both e2e tests + unit tests or just unit tests? zetaclient don't have enough unit tests to run (don't know the current coverage yet) at the moment and can lead to CI failure.

Coverage is for unit test only. For the threshold, it will not make the PR failing if it is not reached.

Copy link
Contributor

@gzukel gzukel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the publish-release pipeline as test run as a part of that pipeline and ensure any changes you made are made in there.

@lumtis lumtis requested a review from gzukel February 21, 2024 16:34
Copy link
Contributor

@gzukel gzukel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lumtis lumtis merged commit a464a54 into develop Feb 21, 2024
@lumtis lumtis deleted the add-codecov branch February 21, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes to CI pipeline or github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add code coverage diff as part of the CI

4 participants