ci: add codecov coverage upload as part of the CI#1781
Conversation
skosito
left a comment
There was a problem hiding this comment.
lgtm, just question how is 60% selected to threshold?
not relevant to this PR, but maybe we can consider using -mode=count heat map flag to get more insight, especially when developing tests locally, which should give how many is each statement covered, i think it should mostly be visible in html reports, but might not be needed
|
Does codecov give combined coverage of both e2e tests + unit tests or just unit tests? zetaclient don't have enough unit tests to run (don't know the current coverage yet) at the moment and can lead to CI failure. |
Just a value taken for now based on our OKR.
Good suggestion, we can think about it in the future
Coverage is for unit test only. For the threshold, it will not make the PR failing if it is not reached. |
gzukel
left a comment
There was a problem hiding this comment.
Can you check the publish-release pipeline as test run as a part of that pipeline and ensure any changes you made are made in there.
Description
Closes: #1704