Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1815 +/- ##
===========================================
- Coverage 39.92% 33.36% -6.57%
===========================================
Files 206 130 -76
Lines 12617 9205 -3412
===========================================
- Hits 5037 3071 -1966
+ Misses 7183 5909 -1274
+ Partials 397 225 -172
|
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
skosito
left a comment
There was a problem hiding this comment.
looks good, couple smaller comments
Co-authored-by: Tanmay <tanmay@zetachain.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
|
Seems like there is bug with Codecov, the diff coverage is -6% while the new addition is almost fully covered, will merge and check if there is a bug, otherwise gonna see what's wrong |
Description
authoritymodule containing objectPoliciesmatching address with policy typesIsAuthorizedfor better unit testingobserver.Params->authority.PoliciesUpdatePoliciesmessage to update the policies.Closes: #1714