Skip to content

feat: message withdraw emissions#1825

Merged
kingpinXD merged 29 commits intodevelopfrom
withdraw-emissions
Mar 5, 2024
Merged

feat: message withdraw emissions#1825
kingpinXD merged 29 commits intodevelopfrom
withdraw-emissions

Conversation

@kingpinXD
Copy link
Member

@kingpinXD kingpinXD commented Mar 1, 2024

Description

Add a message to enable observers to collect emission rewards
Closes: #1653

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@kingpinXD kingpinXD changed the title feate : message withdraw emissions feat : message withdraw emissions Mar 1, 2024
@codecov
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 33.95%. Comparing base (422e00e) to head (f35ffd7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1825      +/-   ##
===========================================
+ Coverage    33.36%   33.95%   +0.59%     
===========================================
  Files          130      132       +2     
  Lines         9205     9253      +48     
===========================================
+ Hits          3071     3142      +71     
+ Misses        5909     5886      -23     
  Partials       225      225              
Files Coverage Δ
.../emissions/keeper/msg_server_withdraw_emissions.go 100.00% <100.00%> (ø)
x/emissions/keeper/withdrawable_emissions.go 100.00% <100.00%> (+100.00%) ⬆️
x/emissions/types/message_withdraw_emissions.go 42.85% <42.85%> (ø)

@kingpinXD kingpinXD changed the title feat : message withdraw emissions feat: message withdraw emissions Mar 2, 2024
@zeta-chain zeta-chain deleted a comment from akimov99900 Mar 4, 2024
kingpinXD and others added 3 commits March 4, 2024 18:12
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
@kingpinXD kingpinXD requested a review from lumtis March 5, 2024 07:10
Copy link
Member

@skosito skosito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just couple of nit picky and typos comments, feel free to disregard if they don't make sense

@kingpinXD kingpinXD merged commit 589e228 into develop Mar 5, 2024
@kingpinXD kingpinXD deleted the withdraw-emissions branch March 5, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emissions : enable withdraw

3 participants