refactor: removing unnecessary pointers in context structure#1831
Merged
refactor: removing unnecessary pointers in context structure#1831
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1831 +/- ##
===========================================
+ Coverage 44.80% 45.11% +0.31%
===========================================
Files 218 219 +1
Lines 12689 12779 +90
===========================================
+ Hits 5685 5765 +80
- Misses 6553 6561 +8
- Partials 451 453 +2
|
skosito
commented
Mar 5, 2024
lumtis
reviewed
Mar 5, 2024
Contributor
|
It's a good direction, I think it simplify the code not using pointer when unnecessary |
lumtis
approved these changes
Mar 5, 2024
Contributor
lumtis
left a comment
There was a problem hiding this comment.
Looks good to me, just some comments on the changelogs
kingpinXD
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
2 parts leftovers from discussions in PR: #1774
add missing unit tests for zeta_core_context
reduce pointers in config/coreContext/appContext
i think pointers should be removed when we want immutability as config, but also considered when there is large struct and mutability (as with core context) so i tried to remove pointers from config struct and also pass config around without pointers (this maybe can be revisited since config might be too big for this?)
Closes: #1807
Type of change
Refactor
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: