refactor: prevent panicking with params#1864
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1864 +/- ##
===========================================
+ Coverage 49.88% 49.95% +0.06%
===========================================
Files 219 220 +1
Lines 12712 12722 +10
===========================================
+ Hits 6342 6355 +13
+ Misses 5928 5925 -3
Partials 442 442
|
lumtis
requested review from
brewmaster012,
fadeev,
kevinssgh,
kingpinXD,
skosito and
ws4charlie
as code owners
skosito
reviewed
Mar 11, 2024
kingpinXD
reviewed
Mar 13, 2024
kingpinXD
reviewed
Mar 13, 2024
kingpinXD
approved these changes
Mar 14, 2024
skosito
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
GetParamsIfExistto prevent panicCloses: #1860