Skip to content

refactor: move TSS vote message from crosschain to observer#1966

Merged
lumtis merged 19 commits intodevelopfrom
refactor-tss-vote
Apr 3, 2024
Merged

refactor: move TSS vote message from crosschain to observer#1966
lumtis merged 19 commits intodevelopfrom
refactor-tss-vote

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Apr 1, 2024

Description

  • Move the message to observer module
  • Rename to MsgVoteTSS
  • Add unit tests for the state transition
  • Add an additional static check: either failure or success observation

Closes: #1926

@lumtis lumtis marked this pull request as ready for review April 1, 2024 13:00
@codecov
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 55.71%. Comparing base (62999f6) to head (15758f7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1966      +/-   ##
===========================================
+ Coverage    55.17%   55.71%   +0.53%     
===========================================
  Files          241      242       +1     
  Lines        13537    13554      +17     
===========================================
+ Hits          7469     7551      +82     
+ Misses        5624     5559      -65     
  Partials       444      444              
Files Coverage Δ
pkg/chains/status.go 100.00% <100.00%> (ø)
x/crosschain/types/authz.go 100.00% <100.00%> (ø)
x/observer/keeper/msg_server_vote_tss.go 100.00% <100.00%> (ø)
x/observer/keeper/utils.go 62.65% <100.00%> (+2.40%) ⬆️
x/observer/types/ballot.go 95.08% <100.00%> (ø)
x/observer/types/message_vote_tss.go 100.00% <100.00%> (ø)
zetaclient/bitcoin/bitcoin_client.go 16.64% <ø> (ø)
zetaclient/evm/evm_client.go 14.89% <ø> (ø)
zetaclient/zetabridge/tx.go 2.65% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lftm , left a minor comment

@lumtis lumtis merged commit 64b898c into develop Apr 3, 2024
@lumtis lumtis deleted the refactor-tss-vote branch April 3, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename CreateTSSVoter to VoteTSSCreation, move to observer and add tests

3 participants