feat: add command to modify genesis before import#1979
Merged
Conversation
Contributor
|
@CharlieMc0 for new suggestions |
kingpinXD
requested review from
brewmaster012,
kevinssgh,
lumtis,
skosito and
ws4charlie
as code owners
lumtis
reviewed
Apr 15, 2024
skosito
reviewed
Apr 17, 2024
Member
skosito
left a comment
skosito
left a comment
There was a problem hiding this comment.
lgtm, just couple of comments, mainly to add some details on modification part for clarity
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
# Conflicts: # cmd/zetacored/parse_genesis.go
lumtis
approved these changes
Apr 19, 2024
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
Looks good to me if it has been tested live
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
skosito
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a command to zeta cored which accepts two genesis files
It copies over the required data from the exported file so that the genesis file can be used to start a network with some state data.
Closes: #1422
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: