test: improve fungible module coverage#1985
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1985 +/- ##
===========================================
+ Coverage 63.91% 65.11% +1.20%
===========================================
Files 236 236
Lines 13639 13610 -29
===========================================
+ Hits 8717 8862 +145
+ Misses 4505 4375 -130
+ Partials 417 373 -44
|
skosito
requested review from
brewmaster012,
kevinssgh,
kingpinXD,
lumtis and
ws4charlie
as code owners
Member
Author
|
@lumtis are params used for this module or is it same as crosschain and should be removed? |
kingpinXD
reviewed
Apr 4, 2024
kingpinXD
reviewed
Apr 4, 2024
kingpinXD
reviewed
Apr 4, 2024
kingpinXD
reviewed
Apr 4, 2024
Member
kingpinXD
left a comment
kingpinXD
left a comment
There was a problem hiding this comment.
lgtm , left a few minor comments
kingpinXD
reviewed
Apr 4, 2024
kingpinXD
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps fungible module coverage from 80 to 90%. Coverage was already improved before (#1742), but this improves it a bit more. This is also last issue in the epic #1739 so epic can also be closed when this is merged.
Closes: #1977
Type of change
Tests
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: