feat(chains): add Amoy testnet chain ID in static chain data#2006
Merged
feat(chains): add Amoy testnet chain ID in static chain data#2006
chains): add Amoy testnet chain ID in static chain data#2006Conversation
lumtis
requested review from
brewmaster012,
kevinssgh,
kingpinXD,
skosito and
ws4charlie
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2006 +/- ##
===========================================
+ Coverage 68.52% 68.54% +0.01%
===========================================
Files 236 236
Lines 13612 13620 +8
===========================================
+ Hits 9328 9336 +8
Misses 3834 3834
Partials 450 450
|
kingpinXD
approved these changes
Apr 11, 2024
skosito
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Amoy testnet information
I think we can close #2002 with it. The best way to handle new chain to be integrated would be to implement #2005 instead
Closes: #2002