Skip to content

test(e2e): add connector bytecode update admin test#2008

Merged
lumtis merged 7 commits intodevelopfrom
e2e-connector-update
Apr 16, 2024
Merged

test(e2e): add connector bytecode update admin test#2008
lumtis merged 7 commits intodevelopfrom
e2e-connector-update

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented Apr 10, 2024

Description

Add an admin test testing ZEVM connector bytecode update

Closes: #1999

Execution example: https://github.com/zeta-chain/node/actions/runs/8644743022/job/23700500386
(the liquidity cap test fails, issue tracked for this one)

@lumtis lumtis marked this pull request as ready for review April 11, 2024 10:29
@github-actions
Copy link

!!!WARNING!!!
nosec detected in the following files: e2e/e2etests/test_update_bytecode_zrc20.go

Be very careful about using #nosec in code. It can be a quick way to suppress security warnings and move forward with development, it should be employed with caution. Suppressing warnings with #nosec can hide potentially serious vulnerabilities. Only use #nosec when you're absolutely certain that the security issue is either a false positive or has been mitigated in another way.

Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203
Broad #nosec annotations should be avoided, as they can hide other vulnerabilities. The CI will block you from merging this PR until you remove #nosec annotations that do not target specific rules.

Pay extra attention to the way #nosec is being used in the files listed above.

@github-actions github-actions bot added the nosec label Apr 15, 2024
@lumtis lumtis requested a review from ws4charlie April 15, 2024 07:54
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lumtis lumtis merged commit 58a1b23 into develop Apr 16, 2024
@lumtis lumtis deleted the e2e-connector-update branch April 16, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add admin E2E test for connector bytecode upgrade

3 participants