refactor(zetaclient): improve some general structure of the codebase#2032
refactor(zetaclient): improve some general structure of the codebase#2032
zetaclient): improve some general structure of the codebase#2032Conversation
|
!!!WARNING!!! Be very careful about using Only suppress a single rule (or a specific set of rules) within a section of code, while continuing to scan for other problems. To do this, you can list the rule(s) to be suppressed within the #nosec annotation, e.g: /* #nosec G401 */ or //#nosec G201 G202 G203 Pay extra attention to the way |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2032 +/- ##
===========================================
- Coverage 70.70% 70.17% -0.54%
===========================================
Files 252 249 -3
Lines 14052 14135 +83
===========================================
- Hits 9936 9919 -17
- Misses 3656 3758 +102
+ Partials 460 458 -2
|
ws4charlie
left a comment
There was a problem hiding this comment.
looks nice. Left a few minor comments.
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
Co-authored-by: Charlie Chen <34498985+ws4charlie@users.noreply.github.com>
skosito
left a comment
There was a problem hiding this comment.
some smaller comments, looks good
Description
Add some improvement in the codebase following this issue: #2026