Skip to content

ci: added local development testing node sync docker compose#2070

Merged
gzukel merged 19 commits intodevelopfrom
ci-add-local-development-testing-node-sync-docker-compose
May 1, 2024
Merged

ci: added local development testing node sync docker compose#2070
gzukel merged 19 commits intodevelopfrom
ci-add-local-development-testing-node-sync-docker-compose

Conversation

@gzukel
Copy link
Contributor

@gzukel gzukel commented Apr 24, 2024

Description

Added two new make commands for building against working branches to launch live fullnode against either testnet or mainnet. This should allow developer to build and test locally with a fully synced node against live network for patch fixes and non-governance upgrades.

This also works if you just want to build from source at runtime.

Closes: DEVOP-641

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

These make commands we're tested locally and its working.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

gzukel added 2 commits April 23, 2024 18:42
…non-governance upgrades against a full node fully synced against testnet or mainnet
…non-governance upgrades against a full node fully synced against testnet or mainnet
@gzukel gzukel added the ci Changes to CI pipeline or github actions label Apr 24, 2024
@github-actions github-actions bot removed the ci Changes to CI pipeline or github actions label Apr 24, 2024
…non-governance upgrades against a full node fully synced against testnet or mainnet
Copy link
Member

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious is this a normal practice to maintain so many compose files , with only some differences in config ?
Would having a script which generates a docker compose file dynamically , based on inputs be easier to maintain ?

@gartnera
Copy link
Contributor

gartnera commented Apr 24, 2024

Just curious is this a normal practice to maintain so many compose files , with only some differences in config ? Would having a script which generates a docker compose file dynamically , based on inputs be easier to maintain ?

Yeah that is an option. Or we could just push all the docker setup down into zetae2e.

Copy link
Member

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ,
As long as all the make commands have been tested

@gzukel gzukel merged commit e5f48e4 into develop May 1, 2024
@gzukel gzukel deleted the ci-add-local-development-testing-node-sync-docker-compose branch May 1, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants