ci: added local development testing node sync docker compose#2070
Merged
ci: added local development testing node sync docker compose#2070
Conversation
…non-governance upgrades against a full node fully synced against testnet or mainnet
…non-governance upgrades against a full node fully synced against testnet or mainnet
…non-governance upgrades against a full node fully synced against testnet or mainnet
kingpinXD
reviewed
Apr 24, 2024
kingpinXD
reviewed
Apr 24, 2024
kingpinXD
reviewed
Apr 24, 2024
kingpinXD
reviewed
Apr 24, 2024
Member
kingpinXD
left a comment
There was a problem hiding this comment.
Just curious is this a normal practice to maintain so many compose files , with only some differences in config ?
Would having a script which generates a docker compose file dynamically , based on inputs be easier to maintain ?
Contributor
Yeah that is an option. Or we could just push all the docker setup down into |
kingpinXD
reviewed
Apr 25, 2024
CharlieMc0
reviewed
Apr 26, 2024
CharlieMc0
reviewed
Apr 26, 2024
kingpinXD
approved these changes
Apr 29, 2024
Member
kingpinXD
left a comment
There was a problem hiding this comment.
Lgtm ,
As long as all the make commands have been tested
lumtis
reviewed
Apr 30, 2024
…nary and updated inline with comments I got
lumtis
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added two new make commands for building against working branches to launch live fullnode against either testnet or mainnet. This should allow developer to build and test locally with a fully synced node against live network for patch fixes and non-governance upgrades.
This also works if you just want to build from source at runtime.
Closes: DEVOP-641
Type of change
How Has This Been Tested?
These make commands we're tested locally and its working.
Checklist: