feat: add develop build version logic#2135
Merged
Conversation
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
skosito and
ws4charlie
as code owners
lumtis
reviewed
May 8, 2024
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
Looks like make install fails for the E2E tests. It runs on my machine
6 tasks
gartnera
force-pushed
the
improve-version-logic
branch
from
f6d2d5f to
094b9d6
Compare
Contributor
Author
fixed |
gartnera
added a commit
that referenced
this pull request
May 8, 2024
lumtis
approved these changes
May 9, 2024
gartnera
added a commit
that referenced
this pull request
May 9, 2024
gartnera
added
no-changelog
kingpinXD
approved these changes
May 9, 2024
Contributor
|
FYI Just added a changelog entry, I think the change is relevant enough for one |
gartnera
added a commit
that referenced
this pull request
May 10, 2024
gartnera
added a commit
that referenced
this pull request
May 10, 2024
* feat: add zetaclientd-supervisor * pass through args directly * clean shutdown * Add optional autodownload * remove old scripts * workround being blocked by #2135 * keep restart-zetaclientd.sh in orchestrator for e2e * lint fixes * feedback updates * autodownload optional and changelog * feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of developnet, we need to stamp the version differently to ensure that we have a new unique version for every build. Release builds will be named based on their tag but develop and local builds will be named based on their timestamp.
This will allow us to deploy developnet changes via governance proposals. Each software update deployed via a governance proposal must have a matching UpgradeHandler configured. Use the version constant in
setup_handlers.goso that thezetacored versionalways matches the upgrade handler version.This also enables #2113 by ensuring that the version numbers in the upgrades/governance proposals match what zetacore says it's version actually is.
Relates to DEVOP-642
Needed for #2095
Type of change
Checklist: