Skip to content

refactor: add cointype check for zevm revert#2169

Merged
gartnera merged 2 commits intodevelopfrom
zevm-revert-cointypecheck-port
May 13, 2024
Merged

refactor: add cointype check for zevm revert#2169
gartnera merged 2 commits intodevelopfrom
zevm-revert-cointypecheck-port

Conversation

@kingpinXD
Copy link
Member

@kingpinXD kingpinXD commented May 13, 2024

Description

  • Add check to revert only ZETA-type transactions.
  • Other txs origination from Zetachain are aborted if they revert

Closes: #2159
Backports: #2160

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@codecov
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.34%. Comparing base (9014044) to head (f277765).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2169   +/-   ##
========================================
  Coverage    72.33%   72.34%           
========================================
  Files          250      250           
  Lines        14041    14046    +5     
========================================
+ Hits         10157    10162    +5     
  Misses        3423     3423           
  Partials       461      461           
Files Coverage Δ
x/crosschain/keeper/processs_outbound.go 93.80% <100.00%> (+0.28%) ⬆️

@gartnera gartnera merged commit dd4ca91 into develop May 13, 2024
@gartnera gartnera deleted the zevm-revert-cointypecheck-port branch May 13, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zetacore : limit zevm revert to cointType Zeta

3 participants