Skip to content

refactor: remove deprecated variables pre-v17#2205

Merged
lumtis merged 7 commits intodevelopfrom
v17/remove-deprecated
May 18, 2024
Merged

refactor: remove deprecated variables pre-v17#2205
lumtis merged 7 commits intodevelopfrom
v17/remove-deprecated

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented May 17, 2024

Description

Remove variable that became deprecated prior to v17.

  • ObserverMapper
  • BlockHeaderFlags in CrosschainFlag
  • Admin policy in observer

Closes: #2133

@lumtis lumtis changed the title refactor: remove deprecated variable pre-v17 refactor: remove deprecated variables pre-v17 May 17, 2024
@codecov
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.25%. Comparing base (cca3253) to head (f61f1a7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2205   +/-   ##
========================================
  Coverage    68.25%   68.25%           
========================================
  Files          259      259           
  Lines        14931    14918   -13     
========================================
- Hits         10191    10183    -8     
+ Misses        4278     4273    -5     
  Partials       462      462           
Files Coverage Δ
x/observer/genesis.go 100.00% <ø> (ø)
...erver/keeper/msg_server_update_crosschain_flags.go 90.90% <100.00%> (-1.10%) ⬇️
x/observer/types/crosschain_flags.go 100.00% <ø> (ø)
.../observer/types/message_update_crosschain_flags.go 100.00% <ø> (ø)
zetaclient/chains/evm/observer/inbound.go 41.04% <ø> (ø)
zetaclient/chains/bitcoin/observer/inbound.go 14.68% <0.00%> (+0.28%) ⬆️

@lumtis lumtis marked this pull request as ready for review May 17, 2024 14:50
Copy link
Contributor

@ws4charlie ws4charlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@lumtis lumtis merged commit a94858e into develop May 18, 2024
@lumtis lumtis deleted the v17/remove-deprecated branch May 18, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated methods pre v17

3 participants