Skip to content

fix: removed hard-coded bitcoin Regnet chainID in E2E withdraw tests#2240

Merged
ws4charlie merged 3 commits intodevelopfrom
fix-live-e2e-testnet
May 22, 2024
Merged

fix: removed hard-coded bitcoin Regnet chainID in E2E withdraw tests#2240
ws4charlie merged 3 commits intodevelopfrom
fix-live-e2e-testnet

Conversation

@ws4charlie
Copy link
Contributor

Description

Removed hard-coded bitcoin chainID in E2E withdraw tests.

Closes:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@codecov
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.10%. Comparing base (6fab9e2) to head (9c4d303).

Current head 9c4d303 differs from pull request most recent head 74cc686

Please upload reports for the commit 74cc686 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2240      +/-   ##
===========================================
+ Coverage    68.08%   68.10%   +0.01%     
===========================================
  Files          259      259              
  Lines        16032    16042      +10     
===========================================
+ Hits         10915    10925      +10     
  Misses        4658     4658              
  Partials       459      459              
Files Coverage Δ
pkg/chains/bitcoin.go 100.00% <100.00%> (ø)

@lumtis lumtis linked an issue May 22, 2024 that may be closed by this pull request
@ws4charlie ws4charlie merged commit a608c4d into develop May 22, 2024
@ws4charlie ws4charlie deleted the fix-live-e2e-testnet branch May 22, 2024 18:14
@ws4charlie ws4charlie restored the fix-live-e2e-testnet branch May 22, 2024 18:34
@lumtis lumtis deleted the fix-live-e2e-testnet branch September 24, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Bitcoin withdraws E2E tests to be run on live network

3 participants