feat: add Optimism and Base in static chain data and rename chain objects#2258
Merged
feat: add Optimism and Base in static chain data and rename chain objects#2258
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2258 +/- ##
========================================
Coverage 68.81% 68.82%
========================================
Files 261 261
Lines 16257 16261 +4
========================================
+ Hits 11187 11191 +4
Misses 4589 4589
Partials 481 481
|
kingpinXD
reviewed
May 24, 2024
kingpinXD
reviewed
May 24, 2024
kingpinXD
reviewed
May 24, 2024
skosito
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
op-stackas a consensus typePerform some renaming for chain objects: remove the chain suffix in the names. The objects are already in the
chainspackage, namespace. Adding this suffix is unnecessary.Closes: #2002