Skip to content

feat: add Optimism and Base in static chain data and rename chain objects#2258

Merged
lumtis merged 23 commits intodevelopfrom
feat/add-optimism-chains
May 27, 2024
Merged

feat: add Optimism and Base in static chain data and rename chain objects#2258
lumtis merged 23 commits intodevelopfrom
feat/add-optimism-chains

Conversation

@lumtis
Copy link
Contributor

@lumtis lumtis commented May 24, 2024

Description

  • Add the following chains in static chain data
    • Optimism mainnet
    • Optimism sepolia
    • Base mainnet
    • Base sepolia

Add op-stack as a consensus type

Perform some renaming for chain objects: remove the chain suffix in the names. The objects are already in the chains package, namespace. Adding this suffix is unnecessary.

Closes: #2002

@codecov
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (632b2b9) to head (1c3a1f7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2258   +/-   ##
========================================
  Coverage    68.81%   68.82%           
========================================
  Files          261      261           
  Lines        16257    16261    +4     
========================================
+ Hits         11187    11191    +4     
  Misses        4589     4589           
  Partials       481      481           
Files Coverage Δ
pkg/chains/bitcoin.go 100.00% <100.00%> (ø)
pkg/chains/chains.go 100.00% <100.00%> (ø)
x/crosschain/migrations/v5/migrate.go 83.07% <100.00%> (ø)
x/lightclient/types/verification_flags.go 86.95% <100.00%> (ø)
x/observer/types/chain_params.go 99.25% <100.00%> (ø)
zetaclient/chains/evm/signer/signer.go 46.30% <100.00%> (ø)
zetaclient/config/config_chain.go 0.00% <ø> (ø)

Copy link
Member

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , left a few NITS

@lumtis lumtis merged commit 4b3ca38 into develop May 27, 2024
@lumtis lumtis deleted the feat/add-optimism-chains branch May 27, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate and add new chain IDs info in chains package depending of potential future considerations

3 participants