feat: initialize cctx gateway interface#2291
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2291 +/- ##
===========================================
+ Coverage 69.26% 69.27% +0.01%
===========================================
Files 274 276 +2
Lines 16537 16563 +26
===========================================
+ Hits 11454 11474 +20
- Misses 4599 4604 +5
- Partials 484 485 +1
|
skosito
commented
May 29, 2024
skosito
commented
May 29, 2024
skosito
commented
May 29, 2024
Member
Author
|
@lumtis just a draft PR for now to see if it's on right track, what do you think? most of the logic is copied and will be refined further with adding |
lumtis
reviewed
May 30, 2024
Contributor
lumtis
left a comment
There was a problem hiding this comment.
I think the direction is good
lumtis
approved these changes
May 31, 2024
lumtis
reviewed
May 31, 2024
Contributor
lumtis
left a comment
There was a problem hiding this comment.
Just changing review, I inadvertently approved on the last one
lumtis
approved these changes
Jun 3, 2024
Contributor
|
Need to run |
kingpinXD
reviewed
Jun 3, 2024
kingpinXD
reviewed
Jun 3, 2024
kingpinXD
reviewed
Jun 3, 2024
kingpinXD
reviewed
Jun 3, 2024
kingpinXD
reviewed
Jun 3, 2024
kingpinXD
reviewed
Jun 3, 2024
kingpinXD
approved these changes
Jun 3, 2024
Member
kingpinXD
left a comment
There was a problem hiding this comment.
lgtm , minor comments have a look before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new CCTXGateway interface and first part of implementation for observers and zevm. Check issue and docs for more details.
Closes: #2276
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: