Skip to content

feat: initialize cctx gateway interface#2291

Merged
skosito merged 27 commits intodevelopfrom
cctx-gateway-interface
Jun 3, 2024
Merged

feat: initialize cctx gateway interface#2291
skosito merged 27 commits intodevelopfrom
cctx-gateway-interface

Conversation

@skosito
Copy link
Member

@skosito skosito commented May 29, 2024

Description

Adds new CCTXGateway interface and first part of implementation for observers and zevm. Check issue and docs for more details.

Closes: #2276

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.

  • Tested CCTX in localnet
  • Tested in development environment
  • Go unit tests
  • Go integration tests
  • Tested via GitHub Actions

Checklist:

  • I have added unit tests that prove my fix feature works

@codecov
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 93.68421% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.27%. Comparing base (8be6ce1) to head (1f0638a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2291      +/-   ##
===========================================
+ Coverage    69.26%   69.27%   +0.01%     
===========================================
  Files          274      276       +2     
  Lines        16537    16563      +26     
===========================================
+ Hits         11454    11474      +20     
- Misses        4599     4604       +5     
- Partials       484      485       +1     
Files Coverage Δ
x/crosschain/keeper/cctx_gateway_observers.go 100.00% <100.00%> (ø)
x/crosschain/keeper/cctx_gateway_zevm.go 100.00% <100.00%> (ø)
x/crosschain/keeper/initiate_outbound.go 100.00% <100.00%> (ø)
x/crosschain/keeper/msg_server_vote_inbound_tx.go 92.00% <33.33%> (-3.84%) ⬇️
app/app.go 2.16% <0.00%> (-0.02%) ⬇️

@skosito
Copy link
Member Author

skosito commented May 29, 2024

@lumtis just a draft PR for now to see if it's on right track, what do you think? most of the logic is copied and will be refined further with adding ValidateOutbound and ValidateInbound.
or scope of this issue is bigger than this?

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the direction is good

@skosito skosito requested a review from lumtis May 30, 2024 14:49
@skosito skosito marked this pull request as ready for review May 30, 2024 14:50
@skosito skosito changed the title feat: cctx gateway interface feat: initialize cctx gateway interface May 30, 2024
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changing review, I inadvertently approved on the last one

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skosito skosito requested a review from lumtis May 31, 2024 18:17
@lumtis
Copy link
Contributor

lumtis commented Jun 3, 2024

Need to run make generate

Copy link
Member

@kingpinXD kingpinXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , minor comments have a look before merging

@skosito skosito merged commit 833a253 into develop Jun 3, 2024
@skosito skosito deleted the cctx-gateway-interface branch June 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initialize a new interface CCTXGateway and add implementations for observers and zevm

3 participants