Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11033145 | Triggered | Generic High Entropy Secret | 7dd8aa6 | cmd/zetae2e/local/accounts.go | View secret |
| 11033146 | Triggered | Generic High Entropy Secret | 7dd8aa6 | cmd/zetae2e/local/accounts.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
lumtis
left a comment
There was a problem hiding this comment.
Would it makes sense to add rpc/backend in test coverage scope?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2294 +/- ##
===========================================
- Coverage 69.68% 68.22% -1.46%
===========================================
Files 281 298 +17
Lines 16644 18857 +2213
===========================================
+ Hits 11598 12865 +1267
- Misses 4570 5355 +785
- Partials 476 637 +161
|
added whole with new issue to add more tests probably will increase, i would like to keep |
Global test coverage only lose 1.5%, this is fine |
Description
Rpc folder was moved from ethermint repo to node, but unit tests weren't. This PR moves existing unit tests as well, with some fixes i will provide in comments so PR is easier to review - otherwise there are no significant changes. Modifications for unit tests to address rpc changes will be added in next PR to make review of those changes easier.
Partially closes: #2283
Type of change
Unit tests
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: