feat: add CheckAuthorization function#2313
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2313 +/- ##
===========================================
+ Coverage 68.22% 68.26% +0.03%
===========================================
Files 298 298
Lines 18857 18880 +23
===========================================
+ Hits 12865 12888 +23
Misses 5355 5355
Partials 637 637
|
kingpinXD
commented
Jun 4, 2024
lumtis
reviewed
Jun 5, 2024
Contributor
lumtis
left a comment
There was a problem hiding this comment.
I would keep the naming Authorizations instead of AuthorizationsList to make it consistent with Policies
Member
Author
The files are named after the data structures for which they have functions. |
Contributor
|
@kingpinXD ready for re-review? |
lumtis
approved these changes
Jun 6, 2024
skosito
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This prs adds a
CheckAuthorizationfunction to replace theIsAuthorizedfunction. The new function uses the authorization list to verify the signer's authorization.Closes: #2310
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: