test(e2e): TestBitcoinDepositRefund, WithdrawBitcoinMultipleTimes#2349
Merged
test(e2e): TestBitcoinDepositRefund, WithdrawBitcoinMultipleTimes#2349
TestBitcoinDepositRefund, WithdrawBitcoinMultipleTimes#2349Conversation
added 7 commits
June 18, 2024 18:29
lumtis
reviewed
Jun 19, 2024
added 2 commits
June 19, 2024 12:28
swift1337
changed the title
DepositBTCRefund, WithdrawBitcoinMultipleTimesTestBitcoinDepositRefund, WithdrawBitcoinMultipleTimes
lumtis
reviewed
Jun 19, 2024
Contributor
lumtis
left a comment
lumtis
left a comment
There was a problem hiding this comment.
We'll need to add the new test in cmd/zetae2e/local/local.go to execute in CI
…into test/deposit-btc-refund
swift1337
requested review from
brewmaster012,
kingpinXD,
skosito and
ws4charlie
as code owners
gartnera
reviewed
Jun 19, 2024
lumtis
reviewed
Jun 19, 2024
Contributor
|
Need to run Note: don't be surprised, this command takes 2 min because we run formatter in the entire codebase (we might want to find some optimization on this) |
added 2 commits
June 20, 2024 13:35
…into test/deposit-btc-refund
skosito
approved these changes
Jun 20, 2024
Member
skosito
left a comment
skosito
left a comment
There was a problem hiding this comment.
looks good, left some comments, please check before merge if they make sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds E2E tests for
TestBitcoinDepositRefundandWithdrawBitcoinMultipleTimes. It also introduces several improvements to testing suite:assertandrequirepackages in e2e testing./e2e/scripts/debug.sh $test $args./e2e/scripts/run.sh $test $argsutils.WaitCctxByInboundHash()with some handy filtersCloses: #1469
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: