refactor: use docker healthcheck for localnet e2e#2353
Merged
Conversation
Contributor
Author
I'm having a hard time telling if e2e is just generally unstable or if this change is causing more instability |
10e5db1 to
b4eda96
Compare
1861866 to
3e7855d
Compare
fa2f875 to
d6afe15
Compare
d6afe15 to
cd4a5f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2353 +/- ##
===========================================
- Coverage 68.72% 68.72% -0.01%
===========================================
Files 302 302
Lines 19168 19169 +1
===========================================
Hits 13174 13174
- Misses 5347 5348 +1
Partials 647 647
|
229ae0d to
bd061d0
Compare
10 tasks
julianrubino
approved these changes
Jun 20, 2024
Member
|
LGTM |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use a docker health check rather than sleeping in e2e to wait for e2e start. Also reduce keygen height.
The keygen height parameters are very sensitive, the following combinations seem to result in random test failures:
I have selected parameters which appear to be stable, but I will need a few CI runs to know for sure.
Reduced CI time by 30-60 seconds, but is mostly to make local development faster.
Update: need to accelerate preparams generation a bit. Also cache it on a docker volume to avoid pointless recomputation when running locally.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Include instructions and any relevant details so others can reproduce.
Checklist: