fix!: set per transaction gas limit to 10M (#3342)

[gartnera]

Port #3342 to develop

No changelog as already released on v25

Summary by CodeRabbit

• New Features
  • Introduced a fixed transaction gas limit of 10,000,000 for all transactions
• Chores
  • Updated variable declarations for consistency in node configuration
  • Simplified gas management by using a predefined transaction gas limit

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces a significant modification to the transaction gas limit configuration in the application. A new constant TransactionGasLimit is defined with a fixed value of 10,000,000, which replaces the previous dynamic gas limit retrieval mechanism. This change standardizes the maximum gas allowed for transactions, removing the flexibility of configurable gas limits in favor of a uniform, predefined threshold.

Changes

File	Change Summary
app/app.go	- Added constant TransactionGasLimit with value 10_000_000 - Modified MaxTxGasWanted to use the new constant directly - Reformatted variable declarations for NodeDir and DefaultNodeHome

Possibly related PRs

• test(e2e): improve E2E reliability for tests on live network #3061: Changes involving gas limit configurations, with similarities to the new TransactionGasLimit constant

Suggested labels

breaking:cli, V2_TESTS

Suggested reviewers

• skosito
• kingpinXD
• brewmaster012
• fbac
• swift1337

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47c9444 and 0b39eb8.

📒 Files selected for processing (1)

• app/app.go (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/app.go (1)

Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: start-e2e-test / e2e

🔇 Additional comments (3)

app/app.go (3)

148-148: LGTM! Clear and well-defined constant declaration.

The constant follows Go naming conventions and uses appropriate type declaration.

---

146-147: LGTM! Clean alignment of variable declarations.

The formatting changes improve readability while maintaining functionality.

---

795-795: Verify gas limit sufficiency for all transaction types.

The fixed gas limit of 10M is reasonable but should be verified against the most complex transaction types in the system.

Run the following script to analyze historical gas usage:

✅ Verification successful

10M gas limit is appropriate for the system's transaction types

The fixed gas limit of 10M is a reasonable and widely accepted limit that aligns with industry standards. Code analysis shows no evidence of transactions requiring higher gas limits, and the system has robust gas management mechanisms in place.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for high gas usage patterns in the codebase

# Look for gas-intensive operations in EVM transactions
ast-grep --pattern 'func ($f) {
  $$$
  gas := $$$
  $$$
}'

# Search for gas-related constants and configurations
rg -A 2 'gas|Gas|GAS' --type go

Length of output: 73190

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.