fix(e2e): use new ErrorMessageRevert field in test

[gartnera]

Revert error message field was added in #3326 but this solana test was not updated.

Summary by CodeRabbit

• Tests
  • Updated end-to-end test for Solana deposit and call transaction to improve error message validation
  • Refined assertion for checking transaction revert error message

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces a modification to the TestSolanaDepositAndCallRevertWithDust end-to-end test in the Solana deposit testing suite. The change focuses on updating the error message assertion, specifically shifting from checking CctxStatus.ErrorMessage to CctxStatus.ErrorMessageRevert. This adjustment refines the test's error validation mechanism, maintaining the core test logic while improving the precision of error message verification.

Changes

File	Change Summary
e2e/e2etests/test_solana_deposit_and_call_revert_with_dust.go	Updated error message assertion to use ErrorMessageRevert instead of ErrorMessage

Possibly related PRs

• fix(e2e): tolerate revert message in both error and status message #2983: Enhances error handling in tests related to revert messages
• fix(e2e): always wait for at least height 1 #3415: Addresses end-to-end test failures related to block height

Suggested labels

UPGRADE_TESTS

Suggested reviewers

• kingpinXD
• ws4charlie
• fbac
• swift1337
• skosito

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lumtis]

LGTM

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

e2e/e2etests/test_solana_deposit_and_call_revert_with_dust.go (1)

33-36: LGTM! The updated error message assertion looks good.

The change correctly uses the new ErrorMessageRevert field and the multi-line format improves readability.

Consider extracting the error message comparison into a helper function for better reusability and maintainability:

+func assertContainsErrorMessage(t require.TestingT, status crosschaintypes.Status, expectedError error) {
+    require.True(t, strings.Contains(status.ErrorMessageRevert, expectedError.Error()))
+}

 func TestSolanaDepositAndCallRevertWithDust(r *runner.E2ERunner, args []string) {
     // ... existing code ...
-    require.True(
-        r,
-        strings.Contains(cctx.CctxStatus.ErrorMessageRevert, crosschaintypes.ErrInvalidWithdrawalAmount.Error()),
-    )
+    assertContainsErrorMessage(r, cctx.CctxStatus, crosschaintypes.ErrInvalidWithdrawalAmount)
 }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 084100a and 1d5d225.

📒 Files selected for processing (1)

• e2e/e2etests/test_solana_deposit_and_call_revert_with_dust.go (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

e2e/e2etests/test_solana_deposit_and_call_revert_with_dust.go (1)

Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: start-solana-test / e2e
• GitHub Check: start-e2e-test / e2e
• GitHub Check: build-and-test
• GitHub Check: Analyze (go)